Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump min Go version to 1.16.8 add Go 1.17.1 #1753

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

Roasbeef
Copy link
Member

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1239844825

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.01%) to 52.9%

Files with Coverage Reduction New Missed Lines %
peer/peer.go 1 76.26%
integration/rpctest/blockgen.go 2 83.67%
btcec/signature.go 3 92.82%
Totals Coverage Status
Change from base Build 1231025212: 0.01%
Covered Lines: 21020
Relevant Lines: 39735

💛 - Coveralls

Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

We were definitely too far behind in our required version there.

@jcvernaleo
Copy link
Member

@Roasbeef we will need to change the required tests to get this in whenever you are ready. Just ping me if you want me to do it.

@Roasbeef
Copy link
Member Author

@jcvernaleo just flipped the settings, tests look good, I think this is good to go now!

@Roasbeef Roasbeef merged commit bca4298 into btcsuite:master Sep 16, 2021
naveensrinivasan added a commit to naveensrinivasan/btcd that referenced this pull request Sep 17, 2021
With this changes btcsuite#1753 merged in
the docker image also has to be upgraded.
jcvernaleo pushed a commit that referenced this pull request Sep 17, 2021
With this changes #1753 merged in
the docker image also has to be upgraded.
sloorush pushed a commit to sloorush/utcd that referenced this pull request Nov 10, 2021
With this changes btcsuite#1753 merged in
the docker image also has to be upgraded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants